Fix Switchbot Curtain BLE connection failures and NaN position values on Raspberry Pi#1229
Merged
donavanbecker merged 4 commits intobeta-4.3.2from Aug 21, 2025
Merged
Fix Switchbot Curtain BLE connection failures and NaN position values on Raspberry Pi#1229donavanbecker merged 4 commits intobeta-4.3.2from
donavanbecker merged 4 commits intobeta-4.3.2from
Conversation
Contributor
Author
|
@donavanbecker 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…ry Pi Co-authored-by: donavanbecker <9875439+donavanbecker@users.noreply.github.com>
Co-authored-by: donavanbecker <9875439+donavanbecker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Bug: Switchbot curtains don't work on Raspberry Pi HomeBridge
Fix Switchbot Curtain BLE connection failures and NaN position values on Raspberry Pi
Aug 20, 2025
donavanbecker
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves critical BLE connection issues with Switchbot Curtain 3 devices on Raspberry Pi HomeBridge that were causing "No characteristics available" errors and NaN position values in HomeKit.
Root Cause Analysis
The issues stemmed from multiple problems in the BLE handling code:
deviceList[0]without checking if the device discovery returned any devices100 - this.serviceData.positioneven whenpositionwas undefined/null, resulting in NaN!== undefined || !== null)Example of the Problem
From the original issue logs:
Changes Made
1. Device Discovery Validation
Before:
After:
2. Position Data Validation
Before:
After:
3. HomeKit NaN Prevention
Added validation in
updateHomeKitCharacteristics():4. Logic Corrections
Fixed validation conditions throughout:
5. Enhanced Error Handling
Improved BLE connection error messages and added guidance for users to consider using BLE/OpenAPI connection type as fallback.
Impact
Testing
Fixes #1226.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.